Remove tests that only assert implementation shape, not behavior

Open
#6,627 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Quiet
Tech stack
python
Domain
testing-qa

Research direction

Start by searching the test suite for assertions of default values or other implementation shape, such as the class priority example. Replace those checks with tests that exercise the behavior using those values, and consider the work done when the relevant tests validate behavior rather than internal structure.

Written by the indexing model from the issue text.

Description

hackbot

Some tests only fail if the code is refactored or if Python itself breaks, for example a test that checks a class's default priority value rather than testing actual behavior of the logic that uses that value. Audit these and replace them with tests that exercise real behavior.

Dominant language
Python
Stars
570
Forks
351
Avg merge
2d 13h
Merged PRs (30d)
65

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mozilla/bugbug

All issues in mozilla/bugbug

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.