mozilla / mozilla/bugbug

Failed review requests should expire after a deadline

Open
#5,870 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

reviewhelper-api
Dominant language
Python
Stars
570
Forks
351
Avg merge
2d 13h
Merged PRs (30d)
65

Description

Currently, failed review requests retry until Cloud Task gives up, leaving the status stuck in RETRY_PENDING or PROCESSING. A deadline should be introduced so that requests exceeding it are automatically marked as expired/failed instead.

The deadline should be set earlier than the Cloud Task retry attempt limit, ensuring the system gracefully expires requests before Cloud Task exhausts all retries.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file, test, or entry point is named in the issue. Trace the review-request retry path and its Cloud Task configuration first; done means requests that exceed the new deadline are marked expired or failed before Cloud Task exhausts its retry limit, rather than remaining in RETRY_PENDING or PROCESSING.

Written by the indexing model from the issue text.

Assessment

Tech stack
gcp, python
Domain
backend, cloud
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.