Don't allow Phabricator AI reviews on patches that have already landed

Open

#5,779 opened on Mar 9, 2026 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 3/5
Estimated time: 1-2 days
Newbie friendliness: 48/100

Issue type: Bug
Clarity: Mostly clear
Activity status: Stale
Tech stack: python
Domain: devtools

Research direction

Start by tracing the code path that allows an AI review to be requested for a Phabricator revision, using the linked D456 review as the reproduction. Done means requests are permitted for WIP or review-needed revisions but rejected once a patch has landed; check the relevant request-handling tests if present.

Written by the indexing model from the issue text.

Description

reviewhelper-api

I just received a notification from Phab of an AI review:

https://phabricator.services.mozilla.com/D456#9938008

This AI review is dated Mar 8 2026, 7:28 PM, this patch landed Jan 31 2018, 4:19 PM.

This is clearly the result of someone experimenting with the AI tool. Clearly there's no value in a review of a patch that landed 8 years ago; this just costs time and money.

Requesting an AI review should only be possible on revisions that are WIP or need review, not after they have landed.

Dominant language: Python
Stars: 570
Forks: 351
Avg merge: 2d 13h
Merged PRs (30d): 65

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

RadioSelectButtonGroup does not render as a button group through bootstrap_field Open

bug

Difficulty 2/5 1-3 hours Newbie friendliness 86/100

zostera/django-bootstrap4#894 · Opened Sep 21, 2026
[Bug]: control_ui.show_thinking = false does not stop the live reasoning stream, so thinking events and done.reasoning_content still reach the web UI Open

Difficulty 2/5 1-3 hours Newbie friendliness 78/100

use-agent-os/agent-os#3276 · Opened Sep 21, 2026
Build fails with LTO enabled: conflicting types for z_shared_sw_isr_table between isr_tables.c and sw_isr_table.h Open

Difficulty 2/5 1-3 hours Newbie friendliness 88/100

zephyrproject-rtos/zephyr#119726 · Opened Sep 21, 2026
[Bug]: redact_sensitive_text does not recognise Discord bot tokens Open

area/auth bug comp/agent P3 platform/discord type/security

Difficulty 2/5 1-3 hours Newbie friendliness 88/100

NousResearch/hermes-agent#117848 · Opened Sep 21, 2026
Windows: hooks treat CLAUDE_PROJECT_DIR (C:/... style) as relative, session summaries written to a doubled path Open

Difficulty 2/5 1-3 hours Newbie friendliness 82/100

zilliztech/memsearch#759 · Opened Sep 21, 2026

More Python issues