Use authenticated requests to fetch files from Phabricator revisions

Open
#5,744 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
api, backend

Research direction

Start by reading bugbug/tools/core/platforms/phabricator.py at lines 312-318, where files are fetched without the Conduit API. Investigate the authenticated Conduit API support that must first be implemented in Phabricator. Done means restricted, non-security revisions can be fetched through authenticated requests.

Written by the indexing model from the issue text.

Description

code-review

Here we fetch the file without going through the Conduit API:
https://github.com/mozilla/bugbug/blob/c600ea07f5a72219c080ec495b744ee5964ce0ee/bugbug/tools/core/platforms/phabricator.py#L312-L318

This limits the ability to fetch changes from restricted revisions, even if they are not security related. Using a Conduit API for that would be a better path. However, we do not have that API yet, so we need to implement it in Phabricator first.

Dominant language
Python
Stars
570
Forks
351
Avg merge
2d 13h
Merged PRs (30d)
65

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mozilla/bugbug

All issues in mozilla/bugbug

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.