mozilla / mozilla/bugbug

`pyppeteer` emits SyntaxWarnings due to invalid escape sequences

Open
#5,720 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

code-review
Dominant language
Python
Stars
570
Forks
351
Avg merge
2d 13h
Merged PRs (30d)
65

Description

pyppeteer is a dependency for requests-html and it is used in bugbug/code_search/searchfox_api.py

/app/.venv/lib/python3.12/site-packages/pyppeteer/us_keyboard_layout.py:73: SyntaxWarning: invalid escape sequence '\('
  'Digit9': {'keyCode': 57, 'code': 'Digit9', 'shiftKey': '\(', 'key': '9'},
/app/.venv/lib/python3.12/site-packages/pyppeteer/us_keyboard_layout.py:143: SyntaxWarning: invalid escape sequence '\<'
  'Comma': {'keyCode': 188, 'code': 'Comma', 'shiftKey': '\<', 'key': ','},
/app/.venv/lib/python3.12/site-packages/pyppeteer/us_keyboard_layout.py:247: SyntaxWarning: invalid escape sequence '\<'
  '<': {'keyCode': 188, 'key': '\<', 'code': 'Comma'},

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the pyppeteer dependency declaration and the use of requests-html in bugbug/code_search/searchfox_api.py. Reproduce the Python 3.12 SyntaxWarnings, then determine the supported dependency-level fix; done means the searchfox code still works without these warnings.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.