mozilla / mozilla/bugbug

[inline_comments_data_collection] Failed to fetch diff: 429 Client Error: Unknown Error for url

Open
#5,222 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
570
Forks
351
Avg merge
2d 13h
Merged PRs (30d)
65

Description

https://github.com/mozilla/bugbug/runs/49275574435:

ERROR:scripts.inline_comments_data_collection:Failed to fetch diff: 429 Client Error: Unknown Error for url: https://phabricator.services.mozilla.com/D2027?vs=50451&id=50454&download=true

  0% 70/109225 [01:06<28:52:38,  1.05it/s]
Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/scripts/inline_comments_data_collection.py", line 104, in process_comments
    fix_patch_id = diff_phid_to_id[most_recent_update["fields"]["new"]]
                   ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'PHID-DIFF-cmwvop63hgl7y62rj3oi'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/bugbug-fixed-comments", line 7, in <module>
    sys.exit(main())
             ^^^^^^
  File "/usr/local/lib/python3.12/site-packages/scripts/inline_comments_data_collection.py", line 187, in main
    for data in process_comments(
                ^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/scripts/inline_comments_data_collection.py", line 106, in process_comments
    diffs = api.search_diffs(diff_phid=most_recent_update["fields"]["new"])
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/libmozdata/phabricator.py", line 252, in search_diffs
    out = self.request(
          ^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/libmozdata/phabricator.py", line 670, in request
    response.raise_for_status()
  File "/usr/local/lib/python3.12/site-packages/requests/models.py", line 1026, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 429 Client Error: Unknown Error for url: https://phabricator.services.mozilla.com/api/differential.diff.search

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with scripts/inline_comments_data_collection.py, especially process_comments, and trace the fallback through libmozdata/phabricator.py and search_diffs. Reproduce or inspect the linked GitHub Actions run and Phabricator request to understand the 429 response. Done means the collection run handles this failure without the shown traceback and can continue processing comments.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-engineering
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.