Unexpected behaviour when overwriting `get_bugs()` to filter bugs and using `get_mail_to_auto_ni()` to set the needinfo in the same tool
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Python
- Stars
- 68
- Forks
- 92
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 16
Description
In such a case, the needinfo request will be set even if the bug gets filtered out after overwriting the get_bugs() method. This happens because get_mail_to_auto_ni() will be executed to set the needinfo in the bughandler() method:
This could be confusing in the future and cause a tool to wrongly needinfo on the excluded bugs.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read auto_nag/bzcleaner.py around bughandler() and the referenced lines 327-338, along with the get_bugs() and get_mail_to_auto_ni() methods. Trace the order in which filtering and needinfo handling occur; done means excluded bugs no longer receive a needinfo request.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100