Ping reviewers after 2 or 3 working days for approved patches by new contributors
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 68
- Forks
- 92
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 16
Description
Right now the bot pings after 2 weeks of inactivity for approved phabricator patches. For patches by new contributors that's... a very long time. It's easy to forget to land patches you didn't author, and the experience for new contributors is bad.
It'd be useful to ping sooner for such patches, ie ones whose owners are folks without lando access and which have not been closed before. (The "not closed before" seems useful to avoid prematurely re-pinging reviewers after backouts.)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the existing bot logic that pings after two weeks of inactivity for approved Phabricator patches. Identify how patch approval, contributor Lando access, and prior closure or backout state are represented. Done means eligible patches from new contributors are pinged after 2 or 3 working days without causing premature repeat pings after backouts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- release, tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100