Not all records in /hibp/breaches endpoint have `LogoUrl`

Open
#2,827 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
api

Research direction

Start with template-helpers/breaches.js at the linked injection point and reproduce the varying LogoUrl counts from /hibp/breaches. Compare the HIBP LogoPath records with the injected output; done when every breach consistently includes LogoUrl and the blurts-schema linter no longer fails.

Written by the indexing model from the issue text.

Description

jira-synced

Re: https://monitor.firefox.com/hibp/breaches

Ctrl+F for "LogoPath" (via HIBP feed). You should get around 655 results (one per breach).
Ctrl+F for "LogoUrl" (which we inject). Each time you refresh you seem to get a different count.

I think we're injecting it here, but not sure why it only seems to inject in some and not others.

Ctrl+F counts [for "LogoUrl"] between refreshes:

  • 41 matches
  • 45 matches
  • 3 matches
  • 31 matches
  • 225 matches

It was breaking my https://github.com/pdehaan/blurts-schema/ linter, so I had to manually inject the CDN urls myself since it didn't like the field intermittently appearing in records.

Dominant language
Fluent
Stars
942
Forks
315
Avg merge
1d 16h
Merged PRs (30d)
19

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mozilla/blurts-server

All issues in mozilla/blurts-server

Similar issues

More Backend & API Design issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.