mozilla / mozilla/blender

setup-target config reads ignore the legacy blender: wrapper

Open Beginner friendly
#146 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
6
Forks
2
Avg merge
1d 11h
Merged PRs (30d)
17

Description

scripts/load-config.py supports a top-level blender: wrapper in a target's .blender/blender.yml (see the blender override branch), but every yq read in .github/actions/setup-target/action.yml uses flat paths only — node_version, python_version, install_command, repo_name, dismiss_unaffected, dismiss_min_confidence. So a wrapped repo config is silently ignored in the remediation job and every value falls back to its default.

Systemic (not specific to any one field) and it fails safe for dismissal (a wrapped repo gets the stricter high default), but it's a real footgun. Fix: make all setup-target reads check the wrapped path before the flat path and default, e.g. yq '.investigate.X // .blender.investigate.X // "default"'.

Surfaced by Copilot review of #145.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the yq reads in .github/actions/setup-target/action.yml and compare their paths with the blender override branch in scripts/load-config.py. Update each named setting so wrapped values take precedence over flat values and defaults, then verify both wrapped and unwrapped target configurations resolve correctly in the remediation job.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, python
Domain
ci-cd, devops
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
85/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.