mozilla / mozilla/blender

fix(automerge): PR merges after human commits that should be reviewed

Open
#121 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
6
Forks
2
Avg merge
1d 11h
Merged PRs (30d)
17

Description

In https://github.com/mozilla/fx-private-relay/pull/6758, we needed to manually intervene and make changes to fix the branch. @groovecoder requested review from @joeherm, but BLEnder merged the PR before that could happen. Ideally, we will not auto-merge a branch that was complicated enough to require intervention.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing BLEnder's automerge handling for pull request 6758 and how it detects human commits or pending review requests. Reproduce the sequence described in the issue, then verify that a branch requiring manual intervention is not merged automatically until the requested review is complete.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, python
Domain
ci-cd, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.