mozilla / mozilla/authenticator-rs

Ensure ClientPinResponse's _retries has correct unused semantics

Open
#86 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
316
Forks
82
Avg merge
4d 20h
Merged PRs (30d)
1

Description

Is _retries really unused? Looks like we always try to set it.

Originally posted by @jcjones in https://github.com/jcjones/authenticator-rs/pull/78

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate ClientPinResponse and all uses of _retries, then read the discussion and implementation context from pull request #78. Determine the intended unused semantics and verify the resulting behavior with the relevant existing tests; done means the field's behavior matches that intent.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
authentication, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.