mozilla / mozilla/authenticator-rs
Use byteorder::ReadBytesExt instead of a local implementation
Open
Nobody has claimed this yet.
enhancement
help wanted
- Dominant language
- Rust
- Stars
- 316
- Forks
- 82
- Avg merge
- 4d 20h
- Merged PRs (30d)
- 1
Description
read_uint_le is very similar to byteorder::ReadBytesExt, as @mozkeeler pointed out:
We should try switching to byteorder::ReadBytesExt (and adding it as a dependency).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/hidproto.rs at read_uint_le, around the lines linked in the issue, and compare the local implementation with byteorder::ReadBytesExt. Add byteorder as a dependency and replace the local approach while preserving the existing little-endian reading behavior; done means the project builds and the existing behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- authentication, security
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100