mozilla-services / mozilla-services/updatebot
Gracefully handle cases where the revision was comandeered
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 9
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
This is super rare, but it shouldn't be difficult to handle.
abandon got back the error
Got an error from phabricator when trying to abandon 260609: {'error': 'ERR-CONDUIT-CORE', 'errorMessage': 'ERR-CONDUIT-CORE: <differential.revision.edit> Validation errors:\n - You can not abandon this revision because you are not the author. You can only abandon revisions you own. You can change this behavior by adjusting the "differential.always-allow-abandon" setting in Config.', 'response': None}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing updatebot's abandon path for Phabricator revision 260609 and inspect how the reported ERR-CONDUIT-CORE validation error is handled. Done means a commandeered revision is handled gracefully rather than producing an unhandled failure, with focused coverage for the non-author case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100