mozilla-services / mozilla-services/updatebot
Detect commandeered revisions
Open
Nobody has claimed this yet.
Enhancement
Medium
- Dominant language
- Python
- Stars
- 9
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
In Bug 1930832 a developer commandeered a phab revision (which is totally fine and encouraged) and later Updatebot tried to abandon it, which failed when it couldn't. The error it got back from phabricator was:
Got an error from phabricator when trying to abandon 228765: {'error': 'ERR-CONDUIT-CORE', 'errorMessage': 'ERR-CONDUIT-CORE: <differential.revision.edit> Validation errors:\n - You can not abandon this revision because you are not the author. You can only abandon revisions you own. You can change this behavior by adjusting the "differential.always-allow-abandon" setting in Config.', 'response': None}
We could detect this error and handle it more gracefully.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing Updatebot's revision-abandoning path and the Phabricator error handling around differential.revision.edit. Use the commandeered-revision error from this issue as the case to handle, and consider the work complete when that failure is detected and handled more gracefully instead of producing the current error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100