mozilla-services / mozilla-services/updatebot

Handle large diffs better

Open
#373 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug
Dominant language
Python
Stars
9
Forks
8
PR merge metrics
No merged PRs in 30d

Description

[task 2024-08-07T18:33:38.856Z] [Debug] (CommandProvider perfetto job_id=535) b"Linting...\nNo lint engine configured for this project.\nRunning unit tests...\nNo unit test engine is configured for this project.\n\n\n Diff for 'third_party/perfetto/sdk/perfetto.h' with context is 7,224,879\n bytes in length. Generally, source changes should not be this large. If\n the file is not a text file, you can mark it 'binary'. Mark this file as\n 'binary' and continue? [y/N] "

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the updatebot run involving third_party/perfetto/sdk/perfetto.h and trace where the large-diff prompt is produced. Read the surrounding diff-handling flow and determine the expected behavior for a 7,224,879-byte diff; done means large diffs are handled without the current problematic interaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.