mozilla-services / mozilla-services/updatebot
Refactor how commitalert handles a new job
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 9
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
In vendoring.py for vendoring tasks, we refactored things so that the first thing we ever do is create a job in the table. This means that if something goes wrong, we won't try continually processing the job.
We don't have the same design for commitalert tasks. (They're a lot rarer, so this hasn't ever come up.) We should probably change how commitalert works so it works similarly.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with vendoring.py and trace how vendoring tasks create a job before processing, then compare that flow with the commitalert task entry point. Done means commitalert follows the same initial job-creation behavior so failures do not continually reprocess the job.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100