mozilla-services / mozilla-services/updatebot
Add applied patch information such that it would be visible in the Phabricator review
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 9
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
Human review accuracy and speed could be improved if information about the patches applied in the patch step could be embedded automatically (perhaps in the commit message) such that it is visible in the Phabricator review. This information would also be very useful for code archeology purposes.
Right now my review process for a manual vendoring is to:
- check the patch stack for changes to the related moz.yaml
- read patches section of the moz.yaml, either from Searchfox, Mercurial, or from Phabricator
- determine if there were any patch changes in this patch set
- look at the correct version of those patches, either in Searchfox, Mercurial, or from Phabricator
- check that each hunk was applied appropriately
While not unreasonable on its face, this process involves a lot of context switches.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the patch step and how updatebot creates commits during manual vendoring. Trace how the patches section of moz.yaml is available, then define what patch information should be embedded so it is visible in Phabricator and supports checking each applied hunk.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100