mozilla-services / mozilla-services/updatebot
Replace calls to .decode() with encoding="UTF-8" in commandrunner.py
Open
Nobody has claimed this yet.
Enhancement
P3
- Dominant language
- Python
- Stars
- 9
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
@ahochheiden pointed out that subprocess.run() has an encoding parameter I didn't know about. I can set it to avoid having to call .decode() everywhere on the output/error streams.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in commandrunner.py by locating the subprocess.run calls and the output or error streams that are followed by .decode(). Replace those decode-based conversions with the subprocess encoding parameter, then verify that all relevant calls are covered and their returned text remains correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100