mozilla-services / mozilla-services/updatebot

Feature request: Add a licencing-change check to the update process.

Open
#190 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Enhancement
Dominant language
Python
Stars
9
Forks
8
PR merge metrics
No merged PRs in 30d

Description

To make sure that we're respectful of software licenses and handling their integration correctly, I'd like to ask that our updater tool include a verification step when licenses change. It should be a rare event - it has been historically, at least - so I think the right thing here is that if a license is changed:

  • the tool should by default fail and provide an error message saying a human should verify the update because of licensing changes in [whatever file], and
  • an explicit "permit-new-license" option be available, that permits license changes to go ahead.

There are other approaches we could take here but in my opinion this is a place that merits manual intervention, so what we want is code that's as dumb as possible and responsible people making explicit decisions.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the updater tool's update process and its option parsing, then inspect how it currently reports verification failures. Determine where license changes can be detected and how the affected file is identified. Done means changed licenses fail by default with a human-review message, while the explicit "permit-new-license" option allows the update to proceed.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.