mozilla-services / mozilla-services/syncstorage-rs
Reject extended offsets under Spanner backend
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.8k
- Forks
- 86
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 21
Description
enabled the extended offsets (optimization) for the non spanner backends.
A side effect of this change is the extractor parses them when under the Spanner backend, where the optional timestamp from the extended offset is then ignored. We should probably reject them in the extractor layer when running under spanner instead of silently ignoring them. The spanner backend doesn’t produce such offsets so this is just an extra sanity check and not very high priority.
┆Issue is synchronized with this Jira Task
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the extractor layer's handling of extended offsets and the Spanner backend path. Trace how the optional timestamp is parsed and ignored under Spanner, then inspect nearby tests if available. Done means extended offsets are rejected for Spanner while remaining accepted by non-Spanner backends.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend, databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100