Adjust TokenserverOrigin variants

Open
#1,722 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
rust
Domain
api, backend

Research direction

Search the codebase for TokenserverOrigin and the Tokenserver purge script to identify where the origin is assigned and consumed. Trace the token-creation path first; done means the origin clearly identifies purge-script-created tokens without retaining the misleading Python label.

Written by the indexing model from the issue text.

Description

TokenserverOrigin was originally added to track the Python vs Rust implementations when both ran in parallel for the Rust version’s rollout: https://github.com/mozilla-services/syncstorage-rs/issues/1245

This tracking via metrics is no longer necessary and can be removed.

However, now that the Python version on the Tokenserver service no longer runs, this field happens to also identify tokens created from the Tokenserver purge script. This can also be useful to track, we should make it clearer what the origin is: e.g. “purge_script” instead of “python”.

┆Issue is synchronized with this Jira Task

Dominant language
Rust
Stars
1.8k
Forks
86
Avg merge
2d 17h
Merged PRs (30d)
21

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mozilla-services/syncstorage-rs

All issues in mozilla-services/syncstorage-rs

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.