mozilla-services / mozilla-services/syncstorage-rs
Make "Invalid DSN" errors consistent in Syncstorage-rs
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.8k
- Forks
- 86
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 21
Description
As we add datastores to syncstorage, we should make the DSN parse errors more consistent.
Right now, we display Spanner or SQLite database_url specified for MySQL feature, please correct. or whatever. Instead we should just use something like
Invalid DSN specified for {} feature, please correct: {} where we specify the feature type and the invalid DSN.
┆Issue is synchronized with this Jira Task
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the DSN parsing entry point and the existing database-specific error messages. Update the errors to use one consistent format containing the feature type and invalid DSN, then run the relevant parser or datastore tests and verify each invalid DSN reports the new wording.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend, databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100