mozilla-services / mozilla-services/syncstorage-rs
Utilize deadpool's Object::pool method
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.8k
- Forks
- 86
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 21
Description
Later version of deadpool support the ability to get the db Pool object from the checked out Object. We should utilize the feature to access a central SpannerSessionSettings via this method instead of copying the settings into every session.
┆Issue is synchronized with this Jira Task
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing SpannerSessionSettings and the deadpool checked-out Object usage in the repository. Confirm how the database Pool is currently obtained and where settings are copied; done means the shared settings are accessed through Object::pool instead of being copied into each session.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend, databases
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100