mozilla-services / mozilla-services/autograph
DRY up signature request log.Fields
Open
Nobody has claimed this yet.
code quality
good first issue
- Dominant language
- Go
- Stars
- 176
- Forks
- 34
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 3
Description
nit: Seeing this set of fields in a number of locations, I wonder if this should be moved to a struct that can output a log.Fields.
Originally posted by @ajvb in https://github.com/mozilla-services/autograph/pull/782#discussion_r723572719
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for the repeated signature request log.Fields definitions and compare the locations that construct them. Identify the shared fields and the existing logging behavior before deciding where a common struct belongs; done means the duplication is reduced without changing the logged data.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100