mozilla-services / mozilla-services/autograph
log and lint addon id and version from xpi SignFile
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 176
- Forks
- 34
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 3
Description
Follow up items from comments and original issue:
- return parsed ID and version to
SignFilein xpi- log parsed ID and version with the "signing operation succeeded" lines instead of from the repacking code
- when signing in mode
ModeAddOnandModeAddOnWithRecommendationcheck the lints:- warn for a missing
manifest.jsonfile - warn for multiple IDs:
applications.gecko.idandbrowser_specific_settings.gecko.id - warn for manifest ID not matching request
Options.ID - warn for a missing
version
- warn for a missing
Warnings return errors if we want to do more linting in autograph and other web extension signers pass for legitimate uses.
Originally posted by @g-k in https://github.com/mozilla-services/autograph/issues/771#issuecomment-929258642
┆Issue is synchronized with this Jira Task
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with handlers.go lines 228-239 and trace the xpi SignFile path, including ModeAddOn and ModeAddOnWithRecommendation. Identify where the parsed ID and version can be returned and logged, then verify that the requested manifest lint warnings cover missing or conflicting IDs, mismatched Options.ID, and missing version.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100