mozilla-services / mozilla-services/autograph

use explicit hsm label key in signer configs

Open
#232 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Go
Stars
176
Forks
34
Avg merge
1d 17h
Merged PRs (30d)
3

Description

Instead of trying to load signer.PrivateKey as PEM then falling back to loading it as an HSM label use explicit hsmlabels as the config key e.g.

signers:
  - id: example
    hsmlabel: examplehsm

This should make it easier to find signers using the HSM (instead of relying on heuristics like the length of the private key or starts with a PEM prefix) for test key gen, management, and rotation for #210 #211 #222

┆Issue is synchronized with this Jira Task

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing signer configuration loading and the current PEM-versus-HSM fallback described in the issue. Review the related work in #210, #211, and #222; done means signer configs accept an explicit hsmlabel key and HSM signers no longer depend on private-key heuristics.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.