mozilla-releng / mozilla-releng/scriptworker
Teach CoT verify about github-pull-request-untrusted `tasks_for`
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 5
- Forks
- 39
- Avg merge
- 4h 18m
- Merged PRs (30d)
- 6
Description
This is a new value that's possible after:
https://phabricator.services.mozilla.com/D157493
Might be as simple as adding a second condition to this if statement:
https://github.com/mozilla-releng/scriptworker/blob/c711a7b467abdc48d9d66ffffd67c88b7fa34003/src/scriptworker/cot/verify.py#L1315
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/scriptworker/cot/verify.py at the condition around line 1315, and review how CoT verification handles existing tasks_for values. Confirm how the github-pull-request-untrusted value from D157493 should be recognized; done means verification accepts this new value correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- security
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100