mozilla-releng / mozilla-releng/scriptworker
Update CoT test data with modern task definitions
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 5
- Forks
- 39
- Avg merge
- 4h 18m
- Merged PRs (30d)
- 6
Description
The test data being used was generated a long time ago (circa cotv2 and cotv4). To help ensure the tests are relevant we should update the definitions with those from recent tasks.
I'm no expert in this regard, but I think the approach I would take is:
- Create
tests/data/cotv7(and add associated constants / helper methods totest_cot_verify.py) - Save modern task definitions there (e.g, decision task, actions.yml, etc)
- Attempt to convert as many tests over to this new data as possible
- Remove
cotv2andcotv4dirs. It might be fine for some tests to continue using the older data, but having a single data dir would simplify things... - Verify no loss in code coverage.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading test_cot_verify.py and the existing tests/data/cotv2 and tests/data/cotv4 directories to understand their constants, helpers, and task definitions. Add tests/data/cotv7 with modern definitions such as the decision task and actions.yml, migrate tests where possible, then remove obsolete data only when coverage remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100