mozilla-releng / mozilla-releng/scriptworker

clean up work and artifact dirs on task claim?

Open
#487 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
5
Forks
39
Avg merge
4h 18m
Merged PRs (30d)
6

Description

Historically, we've created the work and artifact dirs on scriptworker startup, and assume the directories exist and are empty on task claim. This is efficient on docker instances where we don't expect anyone or anything to write to these directories.

On the mac signers, we sometimes ssh in and test something. We currently need to make sure we clean up after ourselves, or the next task that runs can be affected by leftover cruft in the work or artifact dirs. I'm happy with either deleting/recreating these directories on task claim everywhere; or creating a new pref and deleting/recreating if the pref is set.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the task-claim path and the startup code that creates the work and artifact directories. Compare the options of always recreating them or making cleanup conditional on a new preference. Done means leftover files from a prior task or manual signer testing cannot affect the next claimed task, with behavior checked on both Docker workers and Mac signers.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devops
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.