mozilla-releng / mozilla-releng/scriptworker

revisit `require_secret`

Open
#456 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
5
Forks
39
Avg merge
4h 18m
Merged PRs (30d)
6

Description

We no longer have any active need for require_secret, and #455 solves the CI need for it. We may still need require_secret, or additional ssh:// behavior changes, to create releases off of private repos.

Filing this in response to https://github.com/mozilla-releng/scriptworker/pull/455#discussion_r429961435 , where we discussed potentially removing require_secret.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading pull request #455 and the linked discussion, then locate the existing require_secret implementation and related ssh:// behavior. The issue needs a decision about whether those paths are still required for releases from private repositories before a concrete completion condition can be defined.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devops, release
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.