mozilla-releng / mozilla-releng/scriptworker

Integration tests for signal hendling

Open
#375 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
5
Forks
39
Avg merge
4h 18m
Merged PRs (30d)
6

Description

This is a follow up for https://github.com/mozilla-releng/scriptworker/pull/374#pullrequestreview-267417405

It would be great to have integration tests for signal handling. Example tests:

  1. run a script
  2. send SIGTERM
  3. verify it exits within poll_interval

  1. run a script
  2. start a fake task
  3. send SIGTERM
  4. verify it cancels the task and exits within ??? seconds

  1. run a script
  2. send SIGUSR1
  3. verify it exits within poll_interval

  1. run a script
  2. start a fake task
  3. send SIGUSR1
  4. verify it doesn't cancel the task

...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or existing tests are named; start by locating the signal-handling integration-test entry points and the script and fake-task setup. Exercise the listed SIGTERM and SIGUSR1 scenarios, including the unspecified cancellation timeout, and consider the work done when the expected exit and task-cancellation behavior is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.