mozilla-releng / mozilla-releng/scriptworker

Improve error message when dependent task isn't on whitelisted worker

Open
#333 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
5
Forks
39
Avg merge
4h 18m
Merged PRs (30d)
6

Description

I recently ran a pipeline where I used a level 1 build worker that was followed by a level 3 signing worker, which failed the build due to the following error:

scriptworker.exceptions.CoTError: '"signing:parent cCstBL86QWm2XOYZyEoQxg: docker-worker ed25519 cot signature doesn\'t verify against J+PAKmq3jkS2uCpBk5WU2ycrnTFPwZujJT4OHAxm38I=: "'

Though this error describes what happened, I didn't understand it, and had to ping my team to figure out what I should do to diagnose the error.
It would be great if the error message gave a more human-understandable hint of what went wrong.

Potential solution:

  • Describe signing:parent by its task name in addition to the ID, so it's more recognizable by humans
  • Rather than showing the J+PAK... value, describe what it is (a whitelist of sorts?)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the code that formats the scriptworker.exceptions.CoTError for a signing:parent signature or whitelist failure. Check how the parent task name and whitelist value are available at that point; done means the error identifies the task in human-readable terms and explains the value instead of presenting it without context.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.