mozilla-releng / mozilla-releng/scriptworker-scripts
[signingscript] Refactor behaviors and allow taking in all files at once
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 16
- Forks
- 38
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 14
Description
In #957 we bypass task.sign for apple_notarization_stacked behaviour for all-at-once notarization, we should refactor how we handle the list of files.
Entrypoint that needs adjusting in signingscript/src/signingscript/script.py -> async_main, which calls signingscript/src/signingscript/task.py -> sign and then calls each behaviour. This could either mean all behaviours should also take in a list of files to iterate over instead of a single file, or some way of dynamically deciding when a behaviour should or should not take in all files at once.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in signingscript/src/signingscript/script.py at async_main and trace its call to sign in signingscript/src/signingscript/task.py, including how each behaviour receives files. Decide on one consistent approach for list handling or dynamic selection, while preserving the all-at-once apple_notarization_stacked path; done means the behaviours handle the intended file scopes without bypass inconsistencies.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100