mozilla-releng / mozilla-releng/scriptworker-scripts
Beetmover schema required fields not always required
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 16
- Forks
- 38
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 14
Description
@escapewindow on https://github.com/mozilla-releng/scriptworker-scripts/pull/437#discussion_r760599497
Am I right in thinking that these keys may be required in some types of behaviors but not others? If so, we might want to validate that these keys exist for the behaviors that need them... we can do that with multiple jsonschema files (one per behavior?) or by just making sure the task is well-formed for each behavior in the python code.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with beetmoverscript/src/beetmoverscript/data/artifactMap_beetmover_task_schema.json and the referenced discussion on pull request 437 to identify which keys vary by behavior. Confirm whether behavior-specific schemas or Python validation is intended, then add coverage showing that required keys are enforced only for applicable behaviors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, release
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100