mozilla-releng / mozilla-releng/scriptworker-scripts
add signingscript integration tests
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 16
- Forks
- 38
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 14
Description
Ideally, we would be able to catch things like incompatible osslsigncode bustage in signingscript, before we roll out.
Integration tests may look like:
- we run a test in docker-worker, after spinning up a mock Autograph instance; or
- we run a test in a docker-worker instance that lives in a staging-Autograph-enabled subnet; we put non-sensitive secrets somewhere in TC secrets, and sign a bogus file with self-signed certs; or
- something else. I'd like to avoid something overengineered.
As long as we're exercising the signing flow, this should catch this type of bustage; we can add coverage as we find additional paths that need it later.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or existing tests are named. Start by locating the signingscript signing flow and its docker-worker integration points, then compare the proposed mock Autograph and staging-subnet approaches. Done means an integration test exercises signing a bogus file with self-signed certificates and can catch incompatible osslsigncode changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, python
- Domain
- infrastructure, testing-qa
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100