mozilla-releng / mozilla-releng/scriptworker-scripts
[signingscript] support `browser_specific_settings` in `_extension_id`?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 16
- Forks
- 38
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 14
Description
In https://github.com/mozilla-releng/scriptworker-scripts/blob/master/signingscript/src/signingscript/sign.py#L514-L534 , we hardcode our id to applications.gecko.id. It looks like it's also valid to set it to browser_specific_settings.gecko.id, which is more Chrome-compatible. Let's support both.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in signingscript/src/signingscript/sign.py at lines 514-534, where _extension_id is derived from applications.gecko.id. Check how the current id lookup is implemented, then verify support for browser_specific_settings.gecko.id as an alternative and confirm the existing path still works.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100