mozilla-releng / mozilla-releng/mozilla-version
GeckoVersion raises too many different errors when it can't parse a version
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 5
- Forks
- 20
- Avg merge
- 17h 24m
- Merged PRs (30d)
- 2
Description
This is what GeckoVersion raises:
I initially thought it would be a good idea to have distinct error types, but after years of use, mozilla-version users just would like to know if a version was correctly parsed or not. It would be great to change GeckoVersion (and likely BaseVersion too) to just return a single error type.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked section of mozilla_version/gecko.py at lines 103-109, then trace how BaseVersion handles parsing errors. Check the existing version-parsing tests and identify the expected single error type for invalid input; done means GeckoVersion and BaseVersion expose consistent failure behavior without breaking valid-version parsing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100