mozilla-iam / mozilla-iam/auth0-deploy

Add overly matching detection and MozDef alerting to AWS-Federated-AMR.js

Open
#336 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
6
Forks
21
Avg merge
17h 49m
Merged PRs (30d)
5

Description

We should extend the Auth0 rule which creates the amr claim to detect overly matching policy group names (e.g. e) which effectively permit a ton of people and undermine the benefits of the group filtering feature

https://github.com/mozilla-iam/auth0-deploy/blob/master/rules/AWS-Federated-AMR.js

When cases like this are detected we could

  • Alert to MozDef that a overly matching policy was authored
  • Ignore the overly matching group name when filtering
  • Maybe have a whitelist of group names which both match our "is this overly matching" logic but also should indeed be allowed

Original Jira issue IAM-139

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with rules/AWS-Federated-AMR.js and review the linked IAM-139 issue for context. Before coding, clarify whether the change should alert MozDef, ignore overly matching groups, support a whitelist, or combine these behaviors. Done means the intended policy behavior and alerting outcome are agreed and implemented.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
authentication, authorization, security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.