mozilla-iam / mozilla-iam/auth0-deploy
When a client supports only the LDAP connection the `email` input is a `username` input
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 6
- Forks
- 21
- Avg merge
- 17h 49m
- Merged PRs (30d)
- 5
Description
For some reason the lock surfaces the LDAP username/email field differently depending on if LDAP is the only connection type or not. Either file this as a lock bug with auth0, or workaround it or both.
LDAP Connection Only
<div class="auth0-lock-input-block auth0-lock-input-username">
<div class="auth0-lock-input-wrap auth0-lock-input-wrap-with-icon">
<span><svg class="auth0-lock-icon" height="14px" version="1.1" viewbox="0 0 15 16" width="13px" xmlns="http://www.w3.org/2000/svg">
<g fill="none" fill-rule="evenodd" stroke="none" stroke-width="1">
<g fill="#888888" transform="translate(-11.000000, -1471.000000)">
<path d="M25.552,1486.998 L11.449,1486.998 C10.667,1485.799 10.984,1483.399 11.766,1482.6 C12.139,1482.219 14.931,1481.5 16.267,1481.172 C14.856,1480.076 13.995,1478.042 13.995,1476.103 C13.995,1473.284 14.813,1470.999 18.498,1470.999 C22.182,1470.999 23,1473.284 23,1476.103 C23,1478.037 22.145,1480.065 20.74,1481.163 C22.046,1481.489 24.88,1482.228 25.241,1482.601 C26.019,1483.399 26.328,1485.799 25.552,1486.998 L25.552,1486.998 Z M24.6,1483.443 C24.087,1483.169 21.881,1482.548 20,1482.097 L20,1480.513 C21.254,1479.659 21.997,1477.806 21.997,1476.12 C21.997,1473.841 21.414,1471.993 18.499,1471.993 C15.583,1471.993 15,1473.841 15,1476.12 C15,1477.807 15.744,1479.662 17,1480.515 L17,1482.112 C15.109,1482.556 12.914,1483.166 12.409,1483.442 C12.082,1483.854 11.797,1485.173 12,1486 L25,1486 C25.201,1485.174 24.922,1483.858 24.6,1483.443 L24.6,1483.443 Z"></path>
</g>
</g></svg></span><input autocomplete="off" class="auth0-lock-input" name="username " placeholder="your username" type="text" value="">
</div>
</div>
LDAP plus any other connection
<div class="auth0-lock-input-block auth0-lock-input-email">
<div class="auth0-lock-input-wrap auth0-lock-input-wrap-with-icon">
<span><svg class="auth0-lock-icon" height="13px" version="1.1" viewbox="0 0 32 26" width="14px" xmlns="http://www.w3.org/2000/svg">
<g fill="none" fill-rule="evenodd" id="Page-1" sketch:type="MSPage" stroke="none" stroke-width="1">
<g fill="#373A39" id="32px" sketch:type="MSLayerGroup" transform="translate(-2155.000000, -2317.000000)">
<g id="Group-856" sketch:type="MSShapeGroup" transform="translate(1.000000, 1.000000)">
<path d="M2184,2339 C2184,2339.55 2183.55,2340 2183,2340 L2157,2340 C2156.45,2340 2156,2339.55 2156,2339 L2156,2319 C2156,2318.45 2156.45,2318 2157,2318 L2183,2318 C2183.55,2318 2184,2318.45 2184,2319 L2184,2339 L2184,2339 Z M2184,2316 L2156,2316 C2154.89,2316 2154,2316.89 2154,2318 L2154,2340 C2154,2341.1 2154.89,2342 2156,2342 L2184,2342 C2185.1,2342 2186,2341.1 2186,2340 L2186,2318 C2186,2316.89 2185.1,2316 2184,2316 L2184,2316 Z M2176,2322 L2180,2322 L2180,2326 L2176,2326 L2176,2322 Z M2174,2328 L2182,2328 L2182,2320 L2174,2320 L2174,2328 Z M2158,2332 L2172,2332 L2172,2330 L2158,2330 L2158,2332 Z M2158,2336 L2172,2336 L2172,2334 L2158,2334 L2158,2336 Z" id="Fill-419"></path>
</g>
</g>
</g></svg></span><input autocomplete="off" class="auth0-lock-input" name="email" placeholder="yourname@mozilla.com" type="text" value="">
</div>
</div>
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the LDAP-only and LDAP-plus-other-connection cases in the Auth0 Lock hosted page described here; the issue names no repository file or test. Compare the rendered input name, class, and placeholder, then determine whether the result should be reported to Auth0, worked around locally, or both.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- authentication, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100