mourner / mourner/robust-predicates
Orient3d: Clarification needed on behavior of Y axis
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 341
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Description
The README says:
All the functions in this library assume y axis is oriented downwards ↓, so the semantics are different
However when I looked at the code for orient3d, it seems completely identical to Shewchuk's original code (no negations etc. as seen in orient2d)... does this mean the Y axis is right-side up again or am I missing something?
(As far as I'm concerned, the closer to replicating the exact semantics of the original code, the better... so I have no concerns about the Y axis being in the correct orientation, as it makes porting code way easier without having to negate everything. Just want to make sure that's the case... and if so the documentation might need a clarification.)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the README’s y-axis statement and compare the orient3d implementation with orient2d and Shewchuk’s original code. Confirm the intended axis semantics with the project maintainer, then clarify the README so it accurately describes orient3d; done means the documentation resolves whether the original behavior is preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100