motiondivision / motiondivision/motion

[BUG] Animating display from 'block' to 'none' not working since 11.0.11

Open
#2,656 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
33.7k
Forks
1.4k
Avg merge
1d 10h
Merged PRs (30d)
14

Description

1. Read the FAQs 👇

2. Describe the bug

When defining variants with display: block and display: none, the display does not return to none upon triggering the animation.

This worked fine in 11.0.10.

3. IMPORTANT: Provide a CodeSandbox reproduction of the bug

Reproduction

4. Steps to reproduce

Steps to reproduce the behavior:

  1. Go to the sandbox above
  2. Click on the show/hide button to show the overlay
  3. Click on the show/hide button to hide the overlay
  4. Notice that the opacity has animated, but display is still block (notice that the backdrop is still there, because you can't select nay text on the screen)

5. Expected behavior

The overlay should return to display: none as was the case before 11.0.11.

6. Video or screenshots

/

7. Environment details

/

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the StackBlitz reproduction in src/App.tsx and verify the show/hide sequence described in the issue, comparing behavior with versions 11.0.10 and 11.0.11. Trace the display variant handling to identify the regression and verify that hiding the overlay restores display: none without breaking the opacity animation.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.