motiondivision / motiondivision/motion

[BUG] Components wrapped in `motion` don't pass props starting with "drag"

Open
#2,637 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
33.7k
Forks
1.4k
Avg merge
1d 10h
Merged PRs (30d)
14

Description

1. Read the FAQs 👇

2. Describe the bug
When wrapping a component in motion, it causes props starting with drag to not be passed to the underlying wrapped component.

3. IMPORTANT: Provide a CodeSandbox reproduction of the bug
Codesandbox repro

4. Steps to reproduce

Steps to reproduce the behavior:

  1. Go to repro
  2. See that prop starting with drag isn't being passed to wrapped component

5. Expected behavior
For props that start with drag to get passed to wrapped components

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked CodeSandbox reproduction and trace how the motion wrapper filters props before they reach the wrapped component. Verify the behavior with a prop whose name starts with drag; the issue is done when such props are passed through to the underlying component.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.