motiondivision / motiondivision/motion
[BUG] layoutid has incorrect positioning when height adjusts
Open
Nobody has claimed this yet.
bug
- Dominant language
- TypeScript
- Stars
- 33.7k
- Forks
- 1.4k
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 14
Description
These two issues touching on the same bug has still not been properly addressed:
The solution to simply add
wont work for the case when your layoutid is to animate vertically. E.g. imagine a case where you stacked the navigation buttons vertically as opposed to horizontally.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading linked issues #1972 and #2006, then reproduce the layoutId case where a vertically stacked navigation changes height. Compare the suggested workaround with the vertical animation scenario described here. Done means layoutId positioning remains correct when the layout height adjusts, including vertical layouts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 28/100