Building in a Docker Container

Open
#390 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
30/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
docker, node.js
Domain
build-system, cli

Research direction

Start by reproducing the node-lambda package command with --packageDirectory build and --dockerImage node:6, then compare its zip contents with a run without the Docker option. Done means the Docker-based package includes the node_modules folder, or the issue is narrowed to a documented usage error.

Written by the indexing model from the issue text.

Description

question

Is anyone building using the docker image options?

	node-lambda package \
	--packageDirectory build \
	--dockerImage node:6

When I supply a docker container as an option the node_modules folder doesn't show up in the zip file.

When I remove the docker options the zip file seems to be created properly including the node_modules folder. Not sure if this is user error or a bug.

Dominant language
JavaScript
Stars
1.4k
Forks
185
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from motdotla/node-lambda

All issues in motdotla/node-lambda

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.