moodle / moodle/devdocs

[docs] Lack of information about $_GET, $_POST, $_REQUEST, $_COOKIE, and $_SESSION variables

Open
#554 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug documentation help wanted needs-triage
Dominant language
TypeScript
Stars
74
Forks
652
Avg merge
2d 50m
Merged PRs (30d)
12

Description

What is the URL of the page?

https://moodledev.io/general/development/process/peer-review#syntax

What is the issue with this page?

Documentation indicates:

$_GET, $_POST, $_REQUEST, $_COOKIE, and $_SESSION are never used.

But nowhere documentation explains what to do instead.
For $_GET, $_POST and $_REQUEST, we can probably refer to this page.

Also, maybe some superglobals are missing in this list (eg: $_FILES and $_ENV).

Are you able to provide a patch for this?

None

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the syntax section of the peer-review page and review the linked security policy on not trusting user input. Compare the documented superglobals with PHP's superglobals reference, including $_FILES and $_ENV. Done means the documentation explains what to use instead of the listed variables and covers any relevant omissions.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.