Abnormal behaviour for Is in errors.go
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 89
- Forks
- 17
- PR merge metrics
- No merged PRs in 30d
Description
While reviewing different error libraries, I had the chance to read through this one. The design is excellent, but I noticed one issue: if someone calls Is with an empty error code, it currently returns true. This behavior is incorrect — it should never match when no code is provided.
Since the fix is small but important, I’ve raised this PR to address it.
Thanks!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in errors.go and locate the Is implementation. Reproduce the behavior with an empty error code, then verify that an empty code does not match any error. Done means the incorrect true result is eliminated while normal code matching remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100