monzo / monzo/docs

OAuth gateway does not show error messages

Open
#68 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
SCSS
Stars
116
Forks
51
Avg merge
1h 25m
Merged PRs (30d)
1

Description

I have deployed an OAuth application that uses https://auth.monzo.com/, but I forgot to add the production redirect URL. This means that login does not work.

When I click the "Submit" button, nothing happens.

screenshot 2017-08-17 16 44 23

Using the web inspector I can see that the button is initiating a web request which is receiving a 400 status code with the payload:

{
    "code": "bad_request.bad_param.redirect_uri",
    "message": "Mismatched redirect_uri"
}

This makes sense given the error I made, but no error message was shown. It would be great to at least have a generic error message, the literal message provided here might be even better (if not understandable by most).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the OAuth application submission in the documentation site with a mismatched redirect URI, then inspect how the 400 response is handled. Done means the page displays a useful error message instead of appearing to do nothing.

Written by the indexing model from the issue text.

Assessment

Domain
authentication, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.