monkeytypegame / monkeytypegame/monkeytype

Mode2 value isn't reset when Mode is unchecked

Open Beginner friendly
#8,357 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
20.7k
Forks
3.3k
PR merge metrics
No merged PRs in 30d

Description

Did you clear cache before opening an issue?
  • I have cleared my cache
Is there an existing issue for this?
  • I have searched the existing open and closed issues
Does the issue happen when logged in?

Yes

Does the issue happen when logged out?

Yes

Does the issue happen in incognito mode when logged in?

Yes

Does the issue happen in incognito mode when logged out?

Yes

Account name

azurenightlock

Account config

No response

Current Behavior

When you click on share test settings and you select the Mode option and the Mode 2 option. Then unselect the Mode option, Mode 2 option remains selected.

Expected Behavior

When Mode is unselected, Mode 2 should also reset since if the test is not being shared with time selected, then the custom time duration for the said test should also be unselected

Steps To Reproduce
  1. Go to https://monkeytype.com/
  2. Hover over the time settings
  3. Click the arrow popup
  4. Select Mode and then Mode 2
  5. Unselect Mode
Environment
  • OS: Windows 11
  • Browser: Google Chrome
  • Browser Version: Version 151.0.7922.172 (Official Build) (64-bit)
Anything else?
Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the time settings share popup on monkeytype.com and reproduce the sequence of selecting Mode and Mode 2, then unselecting Mode. Trace the settings controls involved and ensure Mode 2 is no longer selected when Mode is cleared; repeat the provided steps to verify the behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
74/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.