monkeytypegame / monkeytypegame/monkeytype

Vietnamese last word bug (duplicated letters)

Open
#7,757 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
20.7k
Forks
3.3k
PR merge metrics
No merged PRs in 30d

Description

Did you clear cache before opening an issue?
  • I have cleared my cache
Is there an existing issue for this?
  • I have searched the existing open and closed issues
Does the issue happen when logged in?

Yes

Does the issue happen when logged out?

Yes

Does the issue happen in incognito mode when logged in?

Yes

Does the issue happen in incognito mode when logged out?

Yes

Account name

kyrie_g

Account config

{"theme":"catppuccin","themeLight":"serika","themeDark":"serika_dark","autoSwitchTheme":false,"customTheme":false,"customThemeColors":["#323437","#e2b714","#e2b714","#646669","#2c2e31","#d1d0c5","#ca4754","#7e2a33","#ca4754","#7e2a33"],"favThemes":[],"showKeyTips":true,"smoothCaret":"fast","codeUnindentOnBackspace":false,"quickRestart":"enter","punctuation":false,"numbers":false,"words":10,"time":15,"mode":"words","quoteLength":[1],"language":"vietnamese_5k","fontSize":6,"freedomMode":false,"difficulty":"normal","blindMode":false,"quickEnd":false,"caretStyle":"underline","paceCaretStyle":"block","flipTestColors":false,"layout":"qwerty","funbox":[],"confidenceMode":"off","indicateTypos":"below","compositionDisplay":"below","timerStyle":"flash_mini","liveSpeedStyle":"off","liveAccStyle":"off","liveBurstStyle":"off","colorfulMode":true,"randomTheme":"off","timerColor":"main","timerOpacity":"1","stopOnError":"off","showAllLines":false,"keymapMode":"react","keymapStyle":"split_matrix","keymapLegendStyle":"lowercase","keymapLayout":"qwerty","keymapShowTopRow":"layout","keymapSize":1.4,"fontFamily":"JetBrains_Mono","smoothLineScroll":true,"alwaysShowDecimalPlaces":false,"alwaysShowWordsHistory":true,"singleListCommandLine":"on","capsLockWarning":true,"playSoundOnError":"off","playSoundOnClick":"1","soundVolume":1,"startGraphsAtZero":true,"showOutOfFocusWarning":true,"paceCaret":"off","paceCaretCustomSpeed":100,"repeatedPace":true,"accountChart":["on","on","on","on"],"minWpm":"off","minWpmCustomSpeed":100,"highlightMode":"letter","typedEffect":"dots","typingSpeedUnit":"wpm","ads":"result","hideExtraLetters":false,"strictSpace":false,"minAcc":"off","minAccCustom":90,"monkey":false,"repeatQuotes":"off","resultSaving":true,"oppositeShiftMode":"off","customBackground":"","customBackgroundSize":"cover","customBackgroundFilter":[0,1,1,1],"customLayoutfluid":["qwerty","dvorak","colemak"],"customPolyglot":["english","spanish","french","german"],"monkeyPowerLevel":"off","minBurst":"off","minBurstCustomSpeed":100,"burstHeatmap":true,"britishEnglish":false,"lazyMode":false,"showAverage":"off","showPb":false,"tapeMode":"letter","tapeMargin":50,"maxLineWidth":0,"playTimeWarning":"off"}

Current Behavior

the site happen trouble handling Vietnamese words that have diacritics (ă, ặ, è, ẹ, ớ, etc.)
at first some word won't even get input.
// EXAMPLE: "đường" (the site will likely don't even record "d" at the start and every letters after that, I need to backspace sometimes for the site to input it)

the final word will always got duplicated with diacritics character
// EXAMPLE: cửa (after typed it all out it will showed as "cưửa" deleting and rewrite doesn't help)

Expected Behavior

base on those 2 examples I provided:
// EXAMPLE: "đường"
-> the site should input and show typed letters like normal

the final word will always got duplicated with diacritics character
// EXAMPLE: cửa
-> the site shouldn't duplicate letters with diacritics

Steps To Reproduce
  1. use "words" or "time" mode.
  2. type like normal (the 2 problems listed above will likely occur from here)
Environment
  • OS: EndeavourOS
  • Browser: Zen Browser (flatpak version)
  • Browser Version: v1.19.5b
Anything else?

I did tried typing Vietnamese long before this update and none of those problem exist aside from the site flagged diacritics as "wrong" or "incorrect", I do want the devs to talk with someone who actually know how Vietnamese work especially the one who's using Telex type.

I also fcitx5 - unikey for Vietnamese

I'm happy to collaborate and answer more questions if it help the devs improve Vietnamese experience on this wonderful site!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in Words or Time mode using the vietnamese_5k language, Zen Browser, and fcitx5-unikey as described. Compare typing and final-word behavior for “đường” and “cửa”; done means Vietnamese diacritics are accepted normally without missed initial input or duplicated final characters.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, internationalization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.